Hi Andy, On Sat, Dec 28, 2024 at 11:36 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > Fri, Dec 27, 2024 at 11:51:50AM +0000, Prabhakar kirjoitti: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Replace raw bitmask values with the `GENMASK()` macro in the `i2c-riic` > > driver to improve readability and maintain consistency. > > ... > > > -#define ICBR_RESERVED 0xe0 /* Should be 1 on writes */ > > +#define ICBR_RESERVED GENMASK(7, 5) /* Should be 1 on writes */ > > I don't understand the comment. Does it mean the value should be 0x20? > Bit's 5-7 are marked as reserved and these should always be set to `1` on write operation. Cheers, Prabhakar
