Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Date: Fri, 11 Oct 2024 16:58:28 +0300
Cc: avifishman70@xxxxxxxxx, tmaimon77@xxxxxxxxx, tali.perry1@xxxxxxxxx, venture@xxxxxxxxxx, yuenn@xxxxxxxxxx, benjaminfair@xxxxxxxxxx, andi.shyti@xxxxxxxxxx, wsa@xxxxxxxxxx, rand.sec96@xxxxxxxxx, wsa+renesas@xxxxxxxxxxxxxxxxxxxx, tali.perry@xxxxxxxxxxx, Avi.Fishman@xxxxxxxxxxx, tomer.maimon@xxxxxxxxxxx, KWLIU@xxxxxxxxxxx, JJLIU0@xxxxxxxxxxx, kfting@xxxxxxxxxxx, openbmc@xxxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <CACD3sJY_79_VTe1EHPdh-1+FCBwb2KCW_N19==TMHAsrFL-rzg@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
References: <20241011055231.9826-1-kfting@nuvoton.com> <20241011055231.9826-3-kfting@nuvoton.com> <ZwkFWVC3_5xr6OQW@smile.fi.intel.com> <CACD3sJY_79_VTe1EHPdh-1+FCBwb2KCW_N19==TMHAsrFL-rzg@mail.gmail.com>

On Fri, Oct 11, 2024 at 09:44:42PM +0800, Tyrone Ting wrote:
> > On Fri, Oct 11, 2024 at 01:52:29PM +0800, Tyrone Ting wrote:

...

> > > +             if (bus->dest_addr & I2C_M_RD)
> >
> > Redundant.
> 
> Just to double check. Is the code "if (bus->dest_addr & I2C_M_RD)" redundant?

Yes.

> > > +                     bus->dest_addr &= ~I2C_M_RD;

-- 
With Best Regards,
Andy Shevchenko

Follow-Ups:
- Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
  - From: Tyrone Ting

References:
- [PATCH v6 0/4] i2c: npcm: read/write operation, checkpatch
  - From: Tyrone Ting
- [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
  - From: Tyrone Ting
- Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
  - From: Andy Shevchenko
- Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
  - From: Tyrone Ting

Prev by Date: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
Next by Date: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
Previous by thread: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
Next by thread: Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment
Index(es):
- Date
- Thread

[Index of Archives] [Linux GPIO] [Linux SPI] [Linux Hardward Monitoring] [LM Sensors] [Linux USB Devel] [Linux Media] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]