Re: [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on HW paramters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 25, 2024 at 12:16:10PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 25, 2024 at 04:04:30PM +0800, Michael Wu wrote:

...

> > + * @bus_loading: for high speed mode, the bus loading affects the high and low
> > + *	pulse width of SCL
> 
> This is bad naming, better is bus_capacitance.

Even more specific bus_capacitance_pf as we usually add physical units to the
variable names, so we immediately understand from the code the order of
numbers and their physical meanings.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux