Hi Shyam, ... > >> Note that the git diff view is presented in two separate lines in order to > >> suppress the checkpatch.pl "CHECKS". > > > > This paragraph should be in comment block rather than commit message body... > > > > I can move it to comment block but in the last version Andi mentioned > that I have to leave a note about the function within one line. > > >> Co-developed-by: Sanket Goswami <Sanket.Goswami@xxxxxxx> > >> Signed-off-by: Sanket Goswami <Sanket.Goswami@xxxxxxx> > >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> > >> --- > > > > ...somewhere here. > > > > ... > > > >> +int piix4_sb800_region_request(struct device *dev, > >> + struct sb800_mmio_cfg *mmio_cfg) > > > > One line? > > > > I am OK to do it, but Andi has a preference to stay within 80 > character wide length. > > Andi, what are you thoughts? I apologize for my earlier review of v4. I failed to notice that you had removed the "static" (which you had properly described). I mistakenly thought you had made an unrelated line adjustment. I'm sorry for requesting a new version. Please feel free to use the format you prefer. Andi PS: I still prefer 80 characters per line, but this is just a personal, non-binding preference.
