On 9/14/2024 00:24, Andy Shevchenko wrote: > On Fri, Sep 13, 2024 at 05:41:05PM +0530, Shyam Sundar S K wrote: >> Export the following i2c_piix4 driver functions as a library so that the >> AMD ASF driver can utilize these core functionalities from the i2c_piix4 >> driver: >> >> - piix4_sb800_region_request(): Request access to a specific SMBus region >> on the SB800 chipset. >> >> - piix4_sb800_region_release(): Release the previously requested SMBus >> region on the SB800 chipset. >> >> - piix4_transaction(): Handle SMBus transactions between the SMBus >> controller and connected devices. >> >> - piix4_sb800_port_sel(): Select the appropriate SMBus port on the SB800 >> chipset. >> >> By making these functions available as a library, enable the AMD ASF >> driver to leverage the established mechanisms in the i2c_piix4 driver, >> promoting code reuse and consistency across different drivers. > >> Note that the git diff view is presented in two separate lines in order to >> suppress the checkpatch.pl "CHECKS". > > This paragraph should be in comment block rather than commit message body... > I can move it to comment block but in the last version Andi mentioned that I have to leave a note about the function within one line. >> Co-developed-by: Sanket Goswami <Sanket.Goswami@xxxxxxx> >> Signed-off-by: Sanket Goswami <Sanket.Goswami@xxxxxxx> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> >> --- > > ...somewhere here. > > ... > >> +int piix4_sb800_region_request(struct device *dev, >> + struct sb800_mmio_cfg *mmio_cfg) > > One line? > I am OK to do it, but Andi has a preference to stay within 80 character wide length. Andi, what are you thoughts? Thanks, Shyam > ... > >> +EXPORT_SYMBOL_GPL(piix4_sb800_region_request); > > Use namespaced exports (with _NS) from day 1. > > ... > >> +void piix4_sb800_region_release(struct device *dev, >> + struct sb800_mmio_cfg *mmio_cfg) > >> +EXPORT_SYMBOL_GPL(piix4_sb800_region_release); > > Same comments as per above. > > ... > >> +EXPORT_SYMBOL_GPL(piix4_transaction); >> +EXPORT_SYMBOL_GPL(piix4_sb800_port_sel); > > _NS >
