Hi Andy: Your comments will be addressed. Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> 於 2024年9月13日 週五 下午6:33寫道： > > On Fri, Sep 13, 2024 at 06:14:44PM +0800, warp5tw@xxxxxxxxx wrote: > > From: Tyrone Ting <kfting@xxxxxxxxxxx> > > > > Store the client address earlier since it might get called in > > the i2c_recover_bus logic flow at the early stage of the function > > npcm_i2c_master_xfer. > > We refer to the functions as func(). > > ... > > > + /* > > + * Previously, the address was stored w/o left-shift by one bit and > > + * with that shift in the following call to npcm_i2c_master_start_xmit. > > + * > > + * Since there are cases that the i2c_recover_bus gets called at the > > + * early stage of the function npcm_i2c_master_xfer, the address is > > Ditto. > > > + * stored with the shift and used in the i2c_recover_bus call. > > + * > > + * The address is stored from bit 1 to bit 7 in the register for > > + * sending the i2c address later so it's left-shifted by 1 bit. > > + */ > > > -- > With Best Regards, > Andy Shevchenko > > Thank you. Regards, Tyrone
