On 04/09/2024 23:54, Andrew Lunn wrote: >> No one is born with experience. You learn as you go. Please note that >> this series has gone through internal review before I posted it in >> upstream. > > Then i'm surprise you were not told to submit lots of smaller > patchsets, one per subsystem, which are complete. We did... multiple times. We gave examples how entire new Qualcomm SoC should be upstreamed, how this process should be organized. We gave trainings. Some listen, some not. Sometimes people do not even come to a training (for free). But there will be always an excuse for patchset doing something entirely different than community expects... The patchset here is a result of some misconceptions and not understanding what is the dependency (claiming there is while there is no) and what are the maintainer trees. > > I get nobody is born with experience, but for a company the size of > Qualcomm, they can easily hire a few experienced mainline developers > who can mentor you, rather than having overloaded Maintainers teach > you the basics, and getting frustrated in the process. Best regards, Krzysztof