On Thu, Aug 15, 2024 at 12:43 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > > Hi Rob, > > thanks for the super-fast review! > > > > "smbus_alert" is a generic interrupt name for controllers, so document > > > it. Introduce also "irq" for the primary interrupt. > > > > I wouldn't add "irq". It's kind of odd in that we have it for I2C > > devices in the first place and we don't try to do that anywhere else. > > Yes, I am actually happy to remove "irq". I only added it for > consistency. > > > > + interrupt-names: > > > + anyOf: > > > + - {} # Any name is allowed. > > > + - items: > > > + enum: > > > + - irq > > > + - smbus_alert > > > > It doesn't really matter with the {}, but the 2nd entry is only true > > if interrupt-names only contains these 2 names. I'd use 'contains' > > rather than 'items' here. > > So, just replace "items:" with "contains:", right? Should I also change > this for I2C targets and add this chunk to patch 2? Oh, I missed that you just copied that, but yes, if you can update that one too, it would be good. Rob