Hi Wojciech,
On Fri, Aug 09, 2024 at 08:17:52AM GMT, Wojciech Siudy (Nokia) wrote:
> From da1630ee3ed664df8fbd74c4063ab130c4e98c5d Mon Sep 17 00:00:00 2001
> From: Wojciech Siudy <wojciech.siudy@xxxxxxxxx>
Nice to see patches from Nokia :-)
> Date: Fri, 9 Aug 2024 09:59:27 +0200
> Subject: [PATCH] pca954x: Reset if channel select fails
please remove the mail header from the commit log.
If you want your name to appear without the "... (Nokia)" part
you can simply add:
From: Wojciech Siudy <wojciech.siudy@xxxxxxxxx>
> Channel selection that has timed out is a symptom of mux'es I2C
> subsystem failure. Without sending reset pulse the POR of entire
> system would be needed to restore the communication.
>
> Signed-off-by: siudy <wojciech.siudy@xxxxxxxxx>
siudy?
...
> @@ -329,6 +345,12 @@ static int pca954x_select_chan(struct i2c_mux_core *muxc, u32 chan)
> ret = pca954x_reg_write(muxc->parent, client, regval);
> data->last_chan = ret < 0 ? 0 : regval;
> }
> + if (ret == -ETIMEDOUT && (data->reset_cont || data->reset_gpio)) {
> + dev_warn(&client->dev, "channel select failed, resetting...\n");
> + pca954x_reset_assert(data);
> + udelay(10);
Why 10?
Andi
