Hi, > > > - .master_xfer = cp2615_i2c_master_xfer, > > > - .functionality = cp2615_i2c_func, > > > + .xfer = cp2615_i2c_xfer, > > > + .functionality = cp2615_i2c_func, > > > }; > > > /* > > > > I don't understand the need for the whitespace changes. > > If you have only one space in such struct initializations, you can > change later only the line you are interested in. If you have aligned > them with tabs, you sometimes change one line and need to realign the > whole block. This is annoying and spoils history a little. TBH looks also better. For just to fields in the struct I don't see it necessary to put the elements in columns. Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx> Andi
