Re: [PATCH v2] i2c: xiic: improve error message when transfer fails to start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Marc,

On Mon, May 13, 2024 at 12:03:24PM GMT, marc.ferland@xxxxxxxxx wrote:
> From: Marc Ferland <marc.ferland@xxxxxxxxxxxx>
> 
> xiic_start_xfer can fail for different reasons:
> 
> - EBUSY: bus is busy or i2c messages still in tx_msg or rx_msg
> - ETIMEDOUT: timed-out trying to clear the RX fifo
> - EINVAL: wrong clock settings
> 
> Both EINVAL and ETIMEDOUT will currently print a specific error
> message followed by a generic one, for example:
> 
>     Failed to clear rx fifo
>     Error xiic_start_xfer
> 
> however EBUSY will simply output the generic message:
> 
>     Error xiic_start_xfer
> 
> which is not really helpful.
> 
> This commit adds a new error message when a busy condition is detected
> and also removes the generic message since it does not provide any
> relevant information to the user.
> 
> Signed-off-by: Marc Ferland <marc.ferland@xxxxxxxxxxxx>
> ---
> Changes in v2:
>  - add a message where the error actually occurs (suggested by
>    Andi Shyti)
>  - remove the generic message completely (Andi Shyti)

Thanks! Pushed to i2c/i2c-host.

Thanks,
Andi




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux