Re: [PATCH v2 4/4] i2c: piix4: Register SPDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/29/24 00:19, Thomas Weißschuh wrote:
On 2024-06-28 16:09:09+0000, Guenter Roeck wrote:
On 6/27/24 10:48, Thomas Weißschuh wrote:
The piix4 I2C bus can carry SPDs, register them if present.
Only look on bus 0, as this is where the SPDs seem to be located.

Only the first 8 slots are supported. If the system has more,
then these will not be visible.

The AUX bus can not be probed as on some platforms it reports all
devices present and all reads return "0".
This would allow the ee1004 to be probed incorrectly.

Was this reported somewhere ? I don't see it happen on any of my systems
(of course that doesn't really mean anything).

It happened on one of the big server systems I tested on.


Signed-off-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>

Reviewed-and-tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Thanks!

FYI, combined tags are discouraged by
Documentation/process/maintainer-tip.rst:

   Please do not use combined tags, e.g. ``Reported-and-tested-by``, as
   they just complicate automated extraction of tags.

I'll add the tags in split form to the patch.


NP with me. though strictly speaking that only applies to the tip tree.
I started using it after someone else asked for it, but I don't like it
too much anyway. Combining it was an attempt to avoid the "please
combine ..." feedback ;-).

On a side note, I also applied the other three patches, but I am not sure
if that counts as "Tested", so I didn't send a tag for those.

Thanks,
Guenter





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux