On 26/04/2024 17:19, Eddie James wrote: >> >>> + The FSI Hub Controller is an FSI controller, providing a number of FSI links, >>> + located on a CFAM. Therefore this node will always be a child of an FSI CFAM >>> + node. >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - ibm,hub-fsi-controller >> Again, is it for specific chip? SoC? Aren't you using generic >> compatibles (not allowed)? > > > This one is fairly universally supported on FSI (any POWER chip will > have it) so I didn't add a specific chip... Should i? Do you mean > generic compatibles are not allowed? How generic do you mean? Maybe IBM is different here, but for every regular SoC the blocks of that SoC should carry SoC model name/number. Best regards, Krzysztof