Re: [PATCH v3 1/2] dt-bindings: hwmon: adm1275: add adm1281

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 25, 2024 at 03:09:47PM +0800, Jose Ramon San Buenaventura wrote:
> Add support for the adm1281 Hot-Swap Controller and Digital Power
> and Energy Monitor
> 
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@xxxxxxxxxx>

I acked this, but I'm having second thoughts. The 1281 follows the same
codepaths in the driver as the 1278, why is the 1278 not used as a
fallback compatible here?

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> index b68061294..5b076d677 100644
> --- a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> @@ -5,7 +5,7 @@
>  $id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
> +title: Analog Devices ADM1075/ADM127x/ADM1281/ADM129x digital power monitors
>  
>  maintainers:
>    - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> @@ -27,6 +27,7 @@ properties:
>        - adi,adm1275
>        - adi,adm1276
>        - adi,adm1278
> +      - adi,adm1281
>        - adi,adm1293
>        - adi,adm1294
>  
> @@ -91,6 +92,7 @@ allOf:
>            contains:
>              enum:
>                - adi,adm1278
> +              - adi,adm1281
>                - adi,adm1293
>                - adi,adm1294
>      then:
> -- 
> 2.39.2
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux