Hi Hans, > > > > + /* > > > > + * if BIOS setting value far from golden value, > > > > + * use golden value and warn user > > > > + */ > > > > + dev_warn(i2c->dev, "speed:%d, fstp:0x%x, golden:0x%x\n", > > > > + params[0], fstp, params[2]); > > > Well, if you want to warn the user, the string should be more > > > descriptive. Maybe "FW settings might cause wrong timings" or whatever > > > these values mean. I don't know. > > > > > > The issues I mentioned could be resolved incrementally from my point of > > > view. Or with a new series. I don't mind. So, in general: > > Same goes for few minor checkpatch warnings. > > > > I will accept incremental patches to fix them... they are mainly > > allignment issues. > > > > OK, the issues you mentioned will be fixed with a new series. Thanks! Looking forward to receiving your new patches. > For the current series patch, do I need to push it to the latest > for-next branch? Or will you push it? I believe you can't push it :-) I am taking care of it! Andi
