On Tue, Feb 27, 2024 at 02:36:33PM +0800, Hans Hu wrote: > Add Zhaoxin I2C controller driver. It provides the access to the i2c > busses, which connects to the touchpad, eeprom, I2S, etc. > > Zhaoxin I2C controller has two separate busses, so may accommodate up > to two I2C adapters. Those adapters are listed in the ACPI namespace > with the "IIC1D17" HID, and probed by a platform driver. > > The driver works with IRQ mode, and supports basic I2C features. Flags > I2C_AQ_NO_ZERO_LEN and I2C_AQ_COMB_WRITE_THEN_READ are used to limit > the unsupported access. > > Signed-off-by: Hans Hu <hanshu-oc@xxxxxxxxxxx> Can't really say anything about the ACPI handling. Looks mostly good for my eyes. > + /* > + * if BIOS setting value far from golden value, > + * use golden value and warn user > + */ > + dev_warn(i2c->dev, "speed:%d, fstp:0x%x, golden:0x%x\n", > + params[0], fstp, params[2]); Well, if you want to warn the user, the string should be more descriptive. Maybe "FW settings might cause wrong timings" or whatever these values mean. I don't know. The issues I mentioned could be resolved incrementally from my point of view. Or with a new series. I don't mind. So, in general: Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
