Hi Jesper, I have taken your patch in my testing branch, but... > + /* Clear pending interrupts from u-boot or misc causes */ > + exynos5_i2c_clr_pend_irq(i2c); > + > + i2c->irq = ret = platform_get_irq(pdev, 0); ... I get this checkpatch note: CHECK: multiple assignments should be avoided #60: FILE: drivers/i2c/busses/i2c-exynos5.c:932: + i2c->irq = ret = platform_get_irq(pdev, 0); You are still in time to fix it, or you can fix it later or you can leave it as for me it's not a big deal. But, please, next time, make sure to run checkpatch before sending a patch. Thanks, Andi