Re: [SPAM] Re: [PATCH v3] i2c: i801: Avoid potential double call to gpiod_remove_lookup_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

> > If registering the platform device fails, the lookup table is
> > removed in the error path. On module removal we would try to
> > remove the lookup table again. Fix this by setting priv->lookup
> > only if registering the platform device was successful.
> > In addition free the memory allocated for the lookup table in
> > the error path.
> >
> > Fixes: d308dfbf62ef ("i2c: mux/i801: Switch to use descriptor passing")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
> > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx>
> > ---
> > v2:
> > - cc stable
> > - free memory allocated for the lookup table
> > v3:
> > - cc'ed Linus
> 
> My bug I guess, mea culpa.
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for your review! I have pushed this patch only in my
testing branch so that i can still add your r-b.

Andi




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux