Hi Heiner,
> + /* Check whether we're a child adapter on a muxed segment */
The comment describes the 'if' but not 'then'. How about sth like "If we
are a child on a muxed segment then limit slots to..."?
> + if (i2c_parent_is_i2c_adapter(adap)) {
> + slot_count = 8;
I don't know much about DMI. I just noticed that there are no printouts
in this code path. Will there be one for the parent?
> + } else {
> + if (slot_count > 8) {
> + dev_err(&adap->dev,
> + "More than 8 memory slots on a single bus, mux config missing?\n");
With this error message, I as a user would think I need to setup a mux
config somewhere. But it is missing from DMI, or? Then, we should
probably use even FW_BUG in the message?
Happy hacking,
Wolfram
Attachment:
signature.asc
Description: PGP signature
