Re: [PATCH 5/6] i2c: designware: Fix RX FIFO depth define on Wangxun 10Gb NIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 31, 2024 at 04:16:51PM +0200, Jarkko Nikula wrote:
> I believe RX FIFO depth define 0 is incorrect on Wangxun 10Gb NIC. It
> must be at least 1 since code is able to read received data from the
> DW_IC_DATA_CMD register.
> 
> For now this define is irrelevant since the txgbe_i2c_dw_xfer_quirk()
> doesn't use the rx_fifo_depth member variable of struct dw_i2c_dev but
> is needed when converting code into generic polling mode implementation.

Shouldn't this formally have a Fixes tag?

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux