Re: [PATCH v3 04/12] i2c: wmt: Reduce redundant: REG_CR setting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Dec 22, 2023 at 10:38:29AM +0100, Wolfram Sang wrote:
> On Thu, Nov 02, 2023 at 10:53:54AM +0800, Hans Hu wrote:
> > These Settings for the same register, REG_CR, 
> > can be put together to reduce code redundancy.
> > 
> > Signed-off-by: Hans Hu <hanshu-oc@xxxxxxxxxxx>
> 
> Some registers require that you first write a certain value, and only
> then can write another value. Have you double checked with datasheets
> that these register writes can safely be aggregated?

I found a WM8505 datasheet and it doesn't say anything about consecutive
writes. And it works on your hardware.

Applied to for-next, thanks!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux