On Thu, Nov 02, 2023 at 10:53:55AM +0800, Hans Hu wrote: > Use more appropriate parameter passing to reduce the amount of code > > Signed-off-by: Hans Hu <hanshu-oc@xxxxxxxxxxx> > --- Because I like most cleanups here: applied to for-next, thanks! But this patch likely reveals a bug in the driver: > -static int wmt_i2c_read(struct i2c_adapter *adap, struct i2c_msg *pmsg, > - int last) > +static int wmt_i2c_read(struct wmt_i2c_dev *i2c_dev, struct i2c_msg *pmsg) It is valid for an I2C transfer, that the last message is a read message. So, instead of dropping it, I think the read function needs to handle 'last' as well. Because this bug is already present in the driver, and I don't want to make rebasing a next version of this series too difficult, I argue that we fix it after your changes are included. Happy hacking!
Attachment:
signature.asc
Description: PGP signature
