> > >> I think this case is a bit too trivial for a helper, it's one line before, and > > >> one line after, so it doesn't really save much. > > I must say I share Michal's skepticism. Because Rafael likes it, I will pick it up. > > > If this pattern is repeated in multiple places, the helper makes sense IMO. > > > > I didn't check each usage in detail, but this should be the places where the new > > helper can be used. > > Another advantage IMO is that the helper, being a function instead of a macro, > > is type-safe. > > If type safety is a concern then I'd rather turn ACPI_COMPANION_SET to > an inline function (which would make more sense than a macro anyway > IMHO, as it has an intended side effect). I guess this can still be done seperately?
Attachment:
signature.asc
Description: PGP signature
