On Mon, Oct 16, 2023 at 6:10 PM Wilczynski, Michal <michal.wilczynski@xxxxxxxxx> wrote: > > Hi, > > On 10/15/2023 11:36 PM, Heiner Kallweit wrote: > > Use new helper acpi_use_parent_companion to simplify the code. > > > > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > > --- > > drivers/i2c/busses/i2c-i801.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > > index a41f5349a..ac223146c 100644 > > --- a/drivers/i2c/busses/i2c-i801.c > > +++ b/drivers/i2c/busses/i2c-i801.c > > @@ -1620,7 +1620,7 @@ static int i801_probe(struct pci_dev *dev, const struct pci_device_id *id) > > priv->adapter.class = I2C_CLASS_HWMON; > > priv->adapter.algo = &smbus_algorithm; > > priv->adapter.dev.parent = &dev->dev; > > - ACPI_COMPANION_SET(&priv->adapter.dev, ACPI_COMPANION(&dev->dev)); > > + acpi_use_parent_companion(&priv->adapter.dev); > > I think this case is a bit too trivial for a helper, it's one line before, and > one line after, so it doesn't really save much. If this pattern is repeated in multiple places, the helper makes sense IMO. > > > priv->adapter.retries = 3; > > > > priv->pci_dev = dev; >
