Re: [PATCH] i2c: designware: Fix corrupted memory seen in the ISR

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/13/2023 4:54 AM, Yann Sionneau wrote:

On 13/09/2023 13:32, Yann Sionneau wrote:

On 13/09/2023 13:22, Andy Shevchenko wrote:
...
To my knowledge the READ_ONCE()/WRITE_ONCE() only imply the use of volatile to access memory thus preventing the compiler to do weird optimizations like merging store/loads, moving store/loads, removing them etc

They don't imply a memory barrier.

Some systems need a memory barrier, to emit a "fence" like instruction, so that the pipeline stalls waiting for the store to "finish", for systems where the writes are posted.

Regards,

Well, for the READ_ONCE() actually I'm wrong, it's overloaded for Alpha and arm64 https://elixir.bootlin.com/linux/latest/C/ident/__READ_ONCE


Hi Yann,

I'll make a new submission with an improved commit message.

I looked at that ARM definition for READ_ONCE/WRITE_ONCE, and those didn't really look like they they addressed this kind of cross-core write visibility, it looked more like it was about avoiding read/write tearing. Read acquire and write release can sometimes replace explicit barrier instructions, but felt adding an explicit barrier was a simpler solution. If this were highly performance critical code, then the benefits of avoiding explicit barriers would be worth a lot more effort.

I know the ARM Barrier docs at https://developer.arm.com/documentation/genc007826/latest/ have an example under "Sending Interrupts and Barriers", page 19, that is very specific that a DSB barrier is required in cases where you write to normal memory on one core and then trigger an interrupt, and the normal memory is read on another core. It explicitly says that even if a memory write to strongly ordered memory (device memory) triggers the interrupt, you would need a DSB barrier. That example seemed like a very good match with what the DW i2c driver was doing.

I also found the video at https://www.youtube.com/watch?v=2I8OHacills had some useful explanations of when barriers are needed. It was a little puzzling in the video, it seemed to say a DMB barrier would be sufficient for this case, even though the ARM barrier docs say a DSB is needed. The DMB only stalls execution of memory accesses, the DSB stalls execution of all instructions. The Linux wmb macro is a DSB barrier on ARM.

Jan




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux