Hi Aryan, kernel test robot noticed the following build warnings: [auto build test WARNING on wsa/i2c/for-next] [also build test WARNING on linus/master v6.6-rc1 next-20230911] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Aryan-Srivastava/THUNDERX_I2C_BLOCK_MODE/20230912-084721 base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next patch link: https://lore.kernel.org/r/20230912002706.2393450-1-aryan.srivastava%40alliedtelesis.co.nz patch subject: [PATCH] THUNDERX_I2C_BLOCK_MODE config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20230912/202309121146.BqM4z7k7-lkp@xxxxxxxxx/config) compiler: alpha-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230912/202309121146.BqM4z7k7-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202309121146.BqM4z7k7-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): >> drivers/i2c/busses/i2c-octeon-core.c:632: warning: Function parameter or member 'i2c' not described in 'octeon_i2c_hlc_block_comp_read' >> drivers/i2c/busses/i2c-octeon-core.c:632: warning: Function parameter or member 'msgs' not described in 'octeon_i2c_hlc_block_comp_read' >> drivers/i2c/busses/i2c-octeon-core.c:632: warning: expecting prototype for high(). Prototype was for octeon_i2c_hlc_block_comp_read() instead >> drivers/i2c/busses/i2c-octeon-core.c:673: warning: Function parameter or member 'i2c' not described in 'octeon_i2c_hlc_block_comp_write' >> drivers/i2c/busses/i2c-octeon-core.c:673: warning: Function parameter or member 'msgs' not described in 'octeon_i2c_hlc_block_comp_write' >> drivers/i2c/busses/i2c-octeon-core.c:673: warning: expecting prototype for high(). Prototype was for octeon_i2c_hlc_block_comp_write() instead vim +632 drivers/i2c/busses/i2c-octeon-core.c 626 627 /** 628 * high-level-controller composite block write+read, msg0=addr, msg1=data 629 * Used in the case where the i2c xfer is for greater than 8 bytes of read data. 630 */ 631 static int octeon_i2c_hlc_block_comp_read(struct octeon_i2c *i2c, struct i2c_msg *msgs) > 632 { 633 int len, ret = 0; 634 u64 cmd = 0; 635 636 octeon_i2c_hlc_enable(i2c); 637 octeon_i2c_block_enable(i2c); 638 639 /* Write (size - 1) into block control register */ 640 len = msgs[1].len - 1; 641 octeon_i2c_writeq_flush((u64)(len), i2c->twsi_base + TWSI_BLOCK_CTL(i2c)); 642 643 /* Prepare core command */ 644 cmd = SW_TWSI_V | SW_TWSI_R | SW_TWSI_SOVR; 645 cmd |= (u64)(msgs[0].addr & 0x7full) << SW_TWSI_ADDR_SHIFT; 646 647 /* Send core command */ 648 ret = octeon_i2c_hlc_cmd(i2c, msgs[0], cmd); 649 if (ret) 650 return ret; 651 652 cmd = __raw_readq(i2c->twsi_base + SW_TWSI(i2c)); 653 if ((cmd & SW_TWSI_R) == 0) 654 return octeon_i2c_check_status(i2c, false); 655 656 /* read data in FIFO */ 657 octeon_i2c_writeq_flush(TWSI_BLOCK_STS_RESET_PTR, i2c->twsi_base + TWSI_BLOCK_STS(i2c)); 658 for (int i = 0; i < len; i += 8) { 659 u64 rd = __raw_readq(i2c->twsi_base + TWSI_BLOCK_FIFO(i2c)); 660 for (int j = 7; j >= 0; j--) 661 msgs[1].buf[i + (7 - j)] = (rd >> (8 * j)) & 0xff; 662 } 663 664 octeon_i2c_block_disable(i2c); 665 return ret; 666 } 667 668 /** 669 * high-level-controller composite block write+write, m[0]len<=2, m[1]len<=1024 670 * Used in the case where the i2c xfer is for greater than 8 bytes of write data. 671 */ 672 static int octeon_i2c_hlc_block_comp_write(struct octeon_i2c *i2c, struct i2c_msg *msgs) > 673 { 674 bool set_ext = false; 675 int i, j, len, ret = 0; 676 u64 cmd, ext = 0; 677 678 octeon_i2c_hlc_enable(i2c); 679 octeon_i2c_block_enable(i2c); 680 681 /* Write (size - 1) into block control register */ 682 len = msgs[1].len - 1; 683 octeon_i2c_writeq_flush((u64)(len), i2c->twsi_base + TWSI_BLOCK_CTL(i2c)); 684 685 /* Prepare core command */ 686 cmd = SW_TWSI_V | SW_TWSI_SOVR; 687 cmd |= (u64)(msgs[0].addr & 0x7full) << SW_TWSI_ADDR_SHIFT; 688 689 if (msgs[0].flags & I2C_M_TEN) 690 cmd |= SW_TWSI_OP_10_IA; 691 else 692 cmd |= SW_TWSI_OP_7_IA; 693 694 if (msgs[0].len == 2) { 695 cmd |= SW_TWSI_EIA; 696 ext |= (u64)msgs[0].buf[0] << SW_TWSI_IA_SHIFT; 697 set_ext = true; 698 cmd |= (u64)msgs[0].buf[1] << SW_TWSI_IA_SHIFT; 699 } else { 700 cmd |= (u64)msgs[0].buf[0] << SW_TWSI_IA_SHIFT; 701 } 702 703 /* Write msg into FIFO buffer */ 704 octeon_i2c_writeq_flush(TWSI_BLOCK_STS_RESET_PTR, i2c->twsi_base + TWSI_BLOCK_STS(i2c)); 705 for (i = 0; i < len; i += 8) { 706 u64 buf = 0; 707 for (j = 7; j >= 0; j--) 708 buf |= (msgs[1].buf[i + (7 - j)] << (8 * j)); 709 octeon_i2c_writeq_flush(buf, i2c->twsi_base + TWSI_BLOCK_FIFO(i2c)); 710 } 711 if (set_ext) 712 octeon_i2c_writeq_flush(ext, i2c->twsi_base + SW_TWSI_EXT(i2c)); 713 714 /* Send command to core (send data in FIFO) */ 715 ret = octeon_i2c_hlc_cmd_send(i2c, cmd); 716 if (ret) 717 return ret; 718 719 cmd = __raw_readq(i2c->twsi_base + SW_TWSI(i2c)); 720 if ((cmd & SW_TWSI_R) == 0) 721 return octeon_i2c_check_status(i2c, false); 722 723 octeon_i2c_block_disable(i2c); 724 return ret; 725 } 726 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
