> From: Andi Shyti <andi.shyti@xxxxxxxxxx> > Sent: 2023年7月26日 7:41 > Hi Carlos, > > > --- a/drivers/i2c/busses/i2c-imx-lpi2c.c > > +++ b/drivers/i2c/busses/i2c-imx-lpi2c.c > > @@ -209,6 +209,9 @@ static int lpi2c_imx_config(struct lpi2c_imx_struct > *lpi2c_imx) > > lpi2c_imx_set_mode(lpi2c_imx); > > > > clk_rate = clk_get_rate(lpi2c_imx->clks[0].clk); > > + if (!clk_rate) > > + return -EINVAL; > > + > > this is a very unlikely to happen and generally not really appreciated. > > If you got so far it's basically impossible that clk_rate is '0'. > Uwe asked you in v2 if you actually had such case. > > I don't have a strong opinion, thoug... I would drop this patch unless Dong is > OK with it and I can accept it with his ack. On MX8X platforms, the default clock rate is 0 if without explicit clock setting in dts nodes. So I wonder it may be worth adding a check here. If you're also ok, feel free to add my tag. Acked-by: Dong Aisheng <Aisheng.dong@xxxxxxx> BTW, please see another reply from Carlos with the test log. Regards Aisheng > > Andi > > > if (lpi2c_imx->mode == HS || lpi2c_imx->mode == ULTRA_FAST) > > filt = 0; > > else > > -- > > 2.34.1 > >
