On 07/06/2023 14:33, Hans Hu wrote:
>>> +
>>> + i2c = devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL);
>>> + if (IS_ERR(i2c)) {
>>> + return dev_err_probe(&pdev->dev, -ENOMEM,
>>> + "devm_kzalloc failed\n");
>> Don't print ENOMEM.
>
>
> will change to just return -ENOMEM;
>
>
>> Run:
>> 1. Checkpatch
>> 2. Coccinelle
>> to fix trivial issues.
>
>
> I used the checkpatch in different versions of the kernel, and there were
> no errors, just a warning about the modify MAINTAINERS, will modify it.
You did not run Coccinelle/coccicheck, so you have trivial issues in the
code. There is no need for us to manually review something which tools
point out.
Please run Coccinelle/coccicheck and fix all errors.
Best regards,
Krzysztof
