Re: [PATCH v3] i2c: add support for Zhaoxin I2C controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,


On 2023/6/7 21:55, Krzysztof Kozlowski wrote:
+static int zxi2c_probe(struct platform_device *pdev)
+{
+	int error;
+	struct zxi2c *i2c;
+	struct pci_dev *pci;
+	struct device *dev;
+
+	/* make sure this is zhaoxin platform */
Why? How can you match to different platform?

In case a platform device named "IIC1D17" is also reported on
non-zhaoxin platform, this driver may also be registered successfully,
even if it shouldn't. In theory.
Why shouldn't it be registered on other platform? It's the same device,
isn't it?


Sorry I didn't make myself clear. I mean, if there is another
non-zhaoxin I2C device with a same reported HID name of 'IIC1D17',
this driver shouldn't it be registered. Because it's not the same device.


Thank you,

Hans



Best regards,
Krzysztof




[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux