On Tue, May 30, 2023 at 5:59 PM Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> wrote: > > Needs tidying up - hopefully can do clock right using ongoing > work from Niyas > https://linaro.atlassian.net/wiki/spaces/CLIENTPC/pages/28832333867/ACPI+Clock+Management I'm wondering how this will be solved for the cases where the "clock-frequency" property is used, see below. > ACPI does not provide an equivalent reset deassert / assert. _RST > doesn't fit that model, so for now make the reset optional. ... > - Left the clock with the hideous hack to keep it obvious that it is > a hack given no way for us to get the clk rate on ACPI firmware yet > and I don't want to pretend there is. The workaround in some cases is to read the "clock-frequency" property, which is standard de facto in several drivers / subsystems. That said, why not split this patch into two and switch the clock to be optional and use the above property? Okay, one thing is that this can collide probably with the generic I2C bus timings, which this driver uses with a non-standard property name. -- With Best Regards, Andy Shevchenko
