Re: [RFC PATCH v2 4/6] i2c: aspeed: switch to generic fw properties.

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, May 30, 2023 at 5:58 PM Jonathan Cameron
<Jonathan.Cameron@xxxxxxxxxx> wrote:
>
> Moving over to generic firmware properties allows this driver to
> get closer to working out of the box with both device tree and
> other firmware options, such as ACPI via PRP0001.
>
> Tested only via QEMU emulation.

...

> -#include <linux/of_address.h>
> -#include <linux/of_platform.h>

> +#include <linux/property.h>

Ah, stupid me. You can discard the previous question (in one of the
previous emails).

...

> +       bus->get_clk_reg_val = (u32 (*)(struct device *, u32))
> +               device_get_match_data(&pdev->dev);

Why not typedef this function and use it here and there?

-- 
With Best Regards,
Andy Shevchenko