On Wed, May 24, 2023 at 05:17:17PM +0800, Jiawen Wu wrote: > Register the platform device to use Designware I2C bus master driver. > Use regmap to read/write I2C device region from given base offset. ... > +#include <linux/platform_device.h> Can this be ordered (to some extent), please? > #include <linux/gpio/property.h> > #include <linux/clk-provider.h> > #include <linux/clkdev.h> > +#include <linux/regmap.h> This too. > #include <linux/i2c.h> > #include <linux/pci.h> Somewhere here... ... Otherwise looks good, thank you. -- With Best Regards, Andy Shevchenko
