On Wed, May 24, 2023 at 05:17:15PM +0800, Jiawen Wu wrote: > Wangxun 10Gb ethernet chip is connected to Designware I2C, to communicate > with SFP. > > Introduce the property "wx,i2c-snps-model" to match device data for Wangxun > in software node case. Since IO resource was mapped on the ethernet driver, > add a model quirk to get regmap from parent device. > > The exists IP limitations are dealt as workarounds: > - IP does not support interrupt mode, it works on polling mode. > - Additionally set FIFO depth address the chip issue. Looks better, thank you! My comments below. ... > + if (device_property_present(&pdev->dev, "wx,i2c-snps-model")) Assuming people are fine with this, I have no objection on the name. > + dev->flags |= MODEL_WANGXUN_SP; You probably has to clear the model in dev_flags, but here still a question which one should have a priority. -- With Best Regards, Andy Shevchenko
