Hi Uwe,
(thunderbird decided to send my first reply as html. Hopefully this
makes it as plain text)
On 9/05/23 08:52, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König<u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-mpc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
> index cfd074ee6d54..a308afb3cca5 100644
> --- a/drivers/i2c/busses/i2c-mpc.c
> +++ b/drivers/i2c/busses/i2c-mpc.c
> @@ -890,15 +890,13 @@ static int fsl_i2c_probe(struct platform_device *op)
> return result;
> };
>
> -static int fsl_i2c_remove(struct platform_device *op)
> +static void fsl_i2c_remove(struct platform_device *op)
> {
> struct mpc_i2c *i2c = platform_get_drvdata(op);
>
> i2c_del_adapter(&i2c->adap);
>
> clk_disable_unprepare(i2c->clk_per);
> -
> - return 0;
> };
>
> static int __maybe_unused mpc_i2c_suspend(struct device *dev)
> @@ -959,7 +957,7 @@ MODULE_DEVICE_TABLE(of, mpc_i2c_of_match);
> /* Structure for a device driver */
> static struct platform_driver mpc_i2c_driver = {
> .probe = fsl_i2c_probe,
> - .remove = fsl_i2c_remove,
> + .remove_new = fsl_i2c_remove,
> .driver = {
> .name = DRV_NAME,
> .of_match_table = mpc_i2c_of_match,
