Reviewed-by: Asmaa Mnebhi <asnaa@xxxxxxxxxx>
> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Sent: Monday, May 8, 2023 4:52 PM
> To: Khalil Blaiech <kblaiech@xxxxxxxxxx>; Asmaa Mnebhi
> <asmaa@xxxxxxxxxx>; Wolfram Sang <wsa@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx
> Subject: [PATCH 38/89] i2c: mlxbf: Convert to platform remove callback
> returning void
>
> The .remove() callback for a platform driver returns an int which makes many
> driver authors wrongly assume it's possible to do error handling by returning
> an error code. However the value returned is (mostly) ignored and this
> typically results in resource leaks. To improve here there is a quest to make
> the remove callback return void. In the first step of this quest all drivers are
> converted to .remove_new() which already returns void.
>
> Trivially convert this driver from always returning zero in the remove callback
> to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/i2c/busses/i2c-mlxbf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c
> index 1810d5791b3d..ae66bdd1b737 100644
> --- a/drivers/i2c/busses/i2c-mlxbf.c
> +++ b/drivers/i2c/busses/i2c-mlxbf.c
> @@ -2433,7 +2433,7 @@ static int mlxbf_i2c_probe(struct platform_device
> *pdev)
> return 0;
> }
>
> -static int mlxbf_i2c_remove(struct platform_device *pdev)
> +static void mlxbf_i2c_remove(struct platform_device *pdev)
> {
> struct mlxbf_i2c_priv *priv = platform_get_drvdata(pdev);
> struct device *dev = &pdev->dev;
> @@ -2474,13 +2474,11 @@ static int mlxbf_i2c_remove(struct
> platform_device *pdev)
> devm_free_irq(dev, priv->irq, priv);
>
> i2c_del_adapter(&priv->adap);
> -
> - return 0;
> }
>
> static struct platform_driver mlxbf_i2c_driver = {
> .probe = mlxbf_i2c_probe,
> - .remove = mlxbf_i2c_remove,
> + .remove_new = mlxbf_i2c_remove,
> .driver = {
> .name = "i2c-mlxbf",
> .acpi_match_table = ACPI_PTR(mlxbf_i2c_acpi_ids),
> --
> 2.39.2
