Hi Oliver Thanks for the review. On Tue, Apr 04, 2023 at 10:53:48AM +0200, Oliver Neukum wrote: > > > On 25.03.23 16:47, Ye Xiang wrote: > > Add sysfs attributes Documentation entries for LJCA device > > Hi, > > do we really want each driver to have its own attribute for that? > It seems to me that that should be unified. Three ABI entries are added in this patch: ljca_version, ljca_trace_level, and ljca_enable_dfu. The first two items are specified for LJCA device and I think they can be kept in sysfs-bus-usb-devices-ljca. But for ljca_enable_dfu, I didn't see a unified DFU entry in sys-bus-usb. I am not sure whether other USB devices have similar DFU mode or not. Any suggestions? Thanks Ye Xiang > > > + > > +What: /sys/bus/usb/.../ljca_enable_dfu > > +Date: July 2023 > > +KernelVersion: 6.4 > > +Contact: Ye Xiang<xiang.ye@xxxxxxxxx> > > +Description: > > + Writing 1 to this file to force the LJCA device into DFU > > + mode so the firmware can be updated. After firmware > > + updating has been done, the device will back to normal > > + working mode.
