Hello Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Thursday, March 9, 2023 4:52 PM > To: Ryan Chen <ryan_chen@xxxxxxxxxxxxxx>; Wolfram Sang > <wsa@xxxxxxxxxx> > Cc: Joel Stanley <joel@xxxxxxxxx>; Brendan Higgins > <brendan.higgins@xxxxxxxxx>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@xxxxxxxxxx>; Andrew Jeffery <andrew@xxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx; Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>; Rob > Herring <robh+dt@xxxxxxxxxx>; Benjamin Herrenschmidt > <benh@xxxxxxxxxxxxxxxxxxx>; linux-aspeed@xxxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > openbmc@xxxxxxxxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx > Subject: Re: [PATCH v6 1/2] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 > > On 07/03/2023 11:09, Ryan Chen wrote: > >>>> 2. Why we do not have it for all controllers with SMBus v3? Why > >>>> this one is special? > >>> > >>> Not all bus is connected with smbus. Most are i2c device connected in > board. > >>> That will be specific statement for each bus. > >> > >> That's not the answer to my question. Why other controllers which can > >> be connected to I2C or SMBus devices do not need this property? > > > > For example following is the board specific connection. > > > > Board A Board B > > ------------------------- ------------------------ > > |i2c bus#1(master/slave) <===fingerprint ===> i2c bus#x (master/slave)| > > |i2c bus#2(master)-> tmp i2c device | | > | > > |i2c bus#3(master)-> adc i2c device | | > | > > ------------------------- ------------------------ > > > > Bus#1 is mctp transfer for each BoardA/B. (Not smbus connected) > > Bus#2 is i2c device connected. > > Bus#3 is i2c device connected. > > You are repeating the same stuff for my question. Where do you see on this > diagram here other I2C controller? How does it answer my question? > You keep repeating same and same, so it won't work. > Sorry, my mis-understand. I don't see many controllers support for timeout feature. I do study with other controllers that is implement it by sw impelement. https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-mlxbf.c#L302-L307 https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-img-scb.c#L52-L55 https://github.com/torvalds/linux/blob/master/drivers/i2c/busses/i2c-omap.c#L588-L596 So I asking for aspeed,timeout property, If it not acceptable, I will default enable timeout in driver. Thanks your guidance. Best regards, Ryan Chen
