On Thu, Nov 17, 2022 at 09:35:31AM +0100, Wolfram Sang wrote: > > > Can you split slave part as a separate change? It will help to review and > > to understand the code better in the future by browsing the history. > > Thanks for all your reviewing help, Andy! Regarding this comment, I > don't think a split is needed. The driver is small enough with ~500 > lines, so I think it can stay this way. It would be different if the > driver was 1000+ lines, then I'd totally agree. I will have a look at > this driver soon. Depends on the ratio "Comments per LoC" by the certain reviewer. My experience with the other drivers for this architecture / platform that they all need much more work before accepting them. And to reduce burden split would be good. But then it's up to you (to me it's a burden for even these 500 LoCs, that are full of room to improvement). -- With Best Regards, Andy Shevchenko
