Re: [PATCH v2 12/12] i2c: designware: Add comment to custom register value constants

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 02, 2022 at 03:11:25PM +0200, Jarkko Nikula wrote:
> DW_IC_COMP_VERSION register contains the ASCII representation of the
> Synopsys component version followed by '*'. Here 0x3131312A == "111*"
> means version 1.11 is required for DW_IC_SDA_HOLD register availability.

The '*' means "any letter, starting from a", so I would put it as 1.11a.
And perhaps explain that the fourth character meaning.
This will be in align with their datasheets.

> DW_IC_COMP_TYPE is constant and is derived from two ASCII letters "DW"
> followed by a 16-bit unsigned number.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux