Re: [PATCH v3] i2c: cadence: Add standard bus recovery support

Michal Simek <michal.simek@xxxxxxx> · Thu, 29 Sep 2022 09:29:29 +0200

Hi Wolfram,

On 9/27/22 22:35, Wolfram Sang wrote:

Applied to for-next, thanks!

Unrelated to this patch, but cppcheck found this issue:

drivers/i2c/busses/i2c-cadence.c:1038:33: warning: Condition 'actual_fscl>fscl' is always false [knownConditionTrueFalse]
   current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) :
                                 ^
drivers/i2c/busses/i2c-cadence.c:1035:19: note: Assuming that condition 'actual_fscl>fscl' is not redundant
   if (actual_fscl > fscl)
                   ^
drivers/i2c/busses/i2c-cadence.c:1038:33: note: Condition 'actual_fscl>fscl' is always false
   current_error = ((actual_fscl > fscl) ? (actual_fscl - fscl) :

I had a glimpse and I think the checker is correct...

Are you still using your ninja-check script?
Can you please share your latest version?

Thanks,
Michal