On 06/07/2022 11:32, Wolfram Sang wrote: > Where are the bindings? Are they already on the way upstream? Already upstream. Documentation/devicetree/bindings/i2c/microchip,corei2c.yaml > >> I'd prefer the latter. Being called "core" is unfortunate and I >> did think about that. i2c-microchip-corei2c would have been my >> first choice but I thought the double usage of i2c would've been >> disapproved of haha > > :) Well, double "i2c" is not exactly pretty but since it is the name of > that IP core... Yeah, and it is the name of /all/ the IP cores we have (: > >>>> + if (idev->msg_len <= 0) >>>> + finished = true; >>> >>> How can it happen that len is < 0? Wouldn't that be an error case? > > Is it to be on the safe side? Ahh sorry, I missed that. msg_len is a u16 so cannot be <0 I'll change it. > >>> Have you testes SMBUS_QUICK as well? >> >> Not specifically SMBUS_QUICK, but I did test with hardware >> that uses "zero-length" messages. > > Good! > >> Thanks for the review :) > > You are welcome. >
