> I'd prefer the latter. Being called "core" is unfortunate and I > did think about that. i2c-microchip-corei2c would have been my > first choice but I thought the double usage of i2c would've been > disapproved of haha :) Well, double "i2c" is not exactly pretty but since it is the name of that IP core... > >> + if (idev->msg_len <= 0) > >> + finished = true; > > > > How can it happen that len is < 0? Wouldn't that be an error case? Is it to be on the safe side? > > Have you testes SMBUS_QUICK as well? > > Not specifically SMBUS_QUICK, but I did test with hardware > that uses "zero-length" messages. Good! > Thanks for the review :) You are welcome.
Attachment:
signature.asc
Description: PGP signature
