Hi Phil, Thanks for your series! On Fri, Jun 24, 2022 at 12:17 PM Phil Edworthy <phil.edworthy@xxxxxxxxxxx> wrote: > The Renesas RZ/V2M SoC (r9a09g011) has a new i2c controller. This series > add the driver. One annoying problem is that the SoC uses a single reset > line for two i2c controllers, and unfortunately one of the controllers > is managed by some firmware, not by Linux. Therefore, the driver just > deasserts the reset. That is actually an integration issue, not an i2c controller issue. Perhaps we need a RESET_IS_CRITICAL flag, cfr. CLK_IS_CRITICAL, to be set by the reset provider? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds