On Mon, Jun 20, 2022 at 12:26 PM Johan Hovold <johan@xxxxxxxxxx> wrote: > On Wed, Jun 15, 2022 at 08:37:45PM -0500, frank zago wrote: ... > > + /* Create an URB for handling interrupt */ > > + dev->irq_urb = usb_alloc_urb(0, GFP_KERNEL); > > + if (!dev->irq_urb) > > + return dev_err_probe(&pdev->dev, -ENOMEM, "Cannot allocate the int URB\n"); > > This isn't how dev_err_probe() is used. While I agree on the below comment, what does this imply? > And allocation failures are already logged so just return -ENOMEM here. -- With Best Regards, Andy Shevchenko
