Hi Wolfram,
On 5/21/22 07:03, Wolfram Sang wrote:
> Hi Frank,
>
> I am not super familiar with USB drivers, so mostly some high level
> review questions first:
>
> On Thu, Mar 31, 2022 at 09:33:06PM -0500, frank zago wrote:
>> The I2C interface can run at 4 different speeds. This driver currently
>> only offer 100MHz. Tested with a variety of I2C sensors, and the IIO
>
> 100kHz.
>
>> subsystem.
>>
>> Signed-off-by: frank zago <frank@xxxxxxxx>
>
> ...
>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index a1bae59208e3..db9797345ad5 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -1199,6 +1199,16 @@ config I2C_RCAR
>>
>> comment "External I2C/SMBus adapter drivers"
>>
>> +config I2C_CH341
>> + tristate "CH341 USB to I2C support"
>> + select MFD_CH341
>
> Hmm, it selects a symbol which depends on USB. Not good AFAIK. I think
> this driver should depend on MFD_CH341.
I've been asked earlier to change it to select.
>> +
>> +/*
>> + * The maximum request size is 4096 bytes, both for reading and
>> + * writing, split in up to 128 32-byte segments. The I2C stream must
>> + * start and stop in each 32-byte segment. Reading must also be split,
>> + * with up to 32-byte per segment.
>> + */
>> +#define SEG_COUNT 128
>
> You mean between every 32 bytes, there is a START and STOP condition on
> the bus? Then, the maximum message size is 32 byte only, sadly. Or did I
> misunderstand?
I've tried to reword that section. The usb command is up to 4kb, but each
32-byte section is a command to the chip, not i2c.
>
> Can the driver send an arbitrary number of messages within one transfer?
> E.g. write, read, read, write, read? All connected with a REPEATED START
> and not with STOP and START?
Yes it can.
>
> ...
>
>> +static u32 ch341_i2c_func(struct i2c_adapter *adap)
>> +{
>> + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
>> +}
>
> Have you also tested zero length messages AKA SMBus Quick commands?
Not properly at the time, although this didn't break the driver.
I've fixed that by adding the special case.
Regards,
Frank
