On Tue, Jun 14, 2022 at 10:11:40AM +0200, Wolfram Sang wrote: > > > Actually this was recommended by Greg in one of our thread here. > > https://lore.kernel.org/all/20200318125003.GA2727094@xxxxxxxxx/ > > It is in the C standard, so any compiler not adhering to it has a bug. Possibly, yes, but for enums that are part of the UAPI, we should explicitly set them to be sure as we do not control what userspace compilers are ever used. Also when dealing with values that are reflected in hardware, it's good to be explicit to help document the interface as well. > It is especially not important here because we use the enums only > locally and do not export. Local stuff is fine, no need to set as there's no abi issues here. thanks, greg k-h
