Hi Wolfram,
On 6/13/22 16:54, Wolfram Sang wrote:
On Mon, Jun 13, 2022 at 10:00:02AM +0530, Shubhrajyoti Datta wrote:
Fix the coverity warning
mixed_enum_type: enumerated type mixed with another type
We are passing an enum in the xiic_wakeup lets change
the function parameters to reflect that.
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
What is the difference to the V2 you sent 4 days earlier?
enum xilinx_i2c_state {
- STATE_DONE,
- STATE_ERROR,
- STATE_START
+ STATE_DONE = 0,
+ STATE_ERROR = 1,
+ STATE_START = 2
No need for initializers.
Actually this was recommended by Greg in one of our thread here.
https://lore.kernel.org/all/20200318125003.GA2727094@xxxxxxxxx/
That's why we started to initialize all values in enums in our code.
It shouldn't be really any problem to do so.
Thanks,
Michal
