[AMD Official Use Only - General]
Hi ,
Thanks for the review
> -----Original Message-----
> From: Wolfram Sang <wsa@xxxxxxxxxx>
> Sent: Monday, June 13, 2022 8:25 PM
> To: Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>
> Cc: linux-i2c@xxxxxxxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>; git
> <git@xxxxxxxxxx>
> Subject: Re: [PATCH v2] i2c-xiic: Fix the type check for xiic_wakeup
>
> On Mon, Jun 13, 2022 at 10:00:02AM +0530, Shubhrajyoti Datta wrote:
> > Fix the coverity warning
> > mixed_enum_type: enumerated type mixed with another type
> >
> > We are passing an enum in the xiic_wakeup lets change the function
> > parameters to reflect that.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
>
> What is the difference to the V2 you sent 4 days earlier?
Some issue with my mailer was not able to see that mail.
>
> > enum xilinx_i2c_state {
> > - STATE_DONE,
> > - STATE_ERROR,
> > - STATE_START
> > + STATE_DONE = 0,
> > + STATE_ERROR = 1,
> > + STATE_START = 2
>
> No need for initializers.
Fixed it in v3.
