Re: [PATCH v1.1 2/2] iio: dac: dac5571: Fix chip id detection for OF devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 28, 2022 at 11:20:54AM +0200, Wolfram Sang wrote:
> 
> > My point is that this patch shouldn't be needed. I'd like if the I2C
> > core could get the driver data from the i2c_device_id table instead of
> > duplicating it in the of_device_id. This isn't possible today as
> > i2c_match_id() doesn't have the fallback mechanism that OF matching has.
> 
> I think the proper fix would be naming the I2C client after the actually
> matched compatible property, and not after the first one? I am a bit
> afraid of regressions when we change that, however...

That would be the right way indeed. I have the same concern regarding
regressions though. Is it worth a try to see what could break ?

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux