On Tue, 2022-03-01 at 22:45 +0100, Wolfram Sang wrote: > On Mon, Feb 14, 2022 at 12:26:30PM +0100, AngeloGioacchino Del Regno > wrote: > > Il 18/01/22 14:33, AngeloGioacchino Del Regno ha scritto: > > > Since depending on the SoC or specific bus functionality some > > > clocks > > > may be optional, we cannot get the benefit of using > > > devm_clk_bulk_get() > > > but, by migrating to clk-bulk, we are able to remove the custom > > > functions > > > mtk_i2c_clock_enable() and mtk_i2c_clock_disable(), increasing > > > common > > > APIs usage, hence (lightly) decreasing kernel footprint. > > > > > > Signed-off-by: AngeloGioacchino Del Regno < > > > angelogioacchino.delregno@xxxxxxxxxxxxx> > > > --- > > > drivers/i2c/busses/i2c-mt65xx.c | 127 +++++++++++++---------- > > > --------- > > > 1 file changed, 51 insertions(+), 76 deletions(-) > > > > > > > Hello, > > this is a friendly ping to request review on this patch as to avoid > > forgetting it. > > > > Adding context, I have tested this patch on multiple (older/newer) > > MediaTek > > platforms. > > Qii Wang, what do you think about this patch? > Sorry for the late reply, I think it's ok.